Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs of pipeline on ascend. #32737

Merged
merged 2 commits into from
May 6, 2021

Conversation

gongweibao
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Describe

Fix macro's bug of pipeline on ascend platform.

@paddle-bot-old
Copy link

paddle-bot-old bot commented May 4, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@gongweibao gongweibao changed the title Fix bugs of pipeline on ascend test=develop Fix bugs of pipeline on ascend. May 4, 2021
sandyhouse
sandyhouse previously approved these changes May 4, 2021
Copy link

@sandyhouse sandyhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongweibao gongweibao requested a review from chenwhql May 6, 2021 03:07
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for framework.py

raise ValueError(
"The Attr(device) should be 'cpu' or 'gpu', and it can also be empty string or None "
"The Attr(device) should be 'cpu' 'npu' or 'gpu', and it can also be empty string or None "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'cpu' 'npu',这里中间是不是应该有个逗号

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will add it later.

@gongweibao gongweibao merged commit c5ae21f into PaddlePaddle:develop May 6, 2021
@gongweibao gongweibao deleted the pipelineascend branch May 6, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants