Add assertion to ensure that size of each dim of paramerter is larger than 0 #33265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be created is larger than 0.
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
Add an assertion to ensure that the size of each dim of the parameter to be created is larger than 0.
When trying to create a parameter that has some dim's size == 0, currently an exception would be raised when the initializer is calculating some shape related statistics. But this exception is not always raised because some dimensions' sizes are not relavant to these statistics and some initializers do not compute such statistics.
So we add an exception to ensure that size of each dimension of the parameter to be created is larger than 0 to avoid consequent errors. A parameter with num_element == 0 is meaningless in this case.