Support index is list bool for getitem in static mode #33298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR's description meets the template requirements! |
|
Thanks for your contribution! |
liym27
force-pushed
the
static_getitem_bool
branch
2 times, most recently
from
2b693f0
to
48cceb8
Compare
liym27
changed the title
zhhsplendid
reviewed
Jun 9, 2021
| new_slice_item = [] | ||
| for idx, ele in enumerate(slice_item): | ||
| if not isinstance(ele, bool): | ||
| raise TypeError("Only support bool in list.") |
There was a problem hiding this comment.
Here the TypeError should be "Mixed bool index with other types is not supported"
"Only support bool in list." may confuse users that we can only use boolean index.
| if not isinstance(i, int): | ||
| raise TypeError("Only support int value in list") | ||
| if not isinstance(i, (int, bool)): | ||
| raise TypeError("Only support int or bool in list.") |
There was a problem hiding this comment.
"Only support int or bool in list" -> "Only support int or bool in index list"
Otherwise users may be confused about the list thing, them may not know we refer to the index list.
liym27
force-pushed
the
static_getitem_bool
branch
from
48cceb8
to
6b366f9
Compare
liym27
added a commit
to liym27/Paddle
that referenced
this pull request
Jun 11, 2021
lanxianghit
pushed a commit
that referenced
this pull request
Jun 15, 2021
…ist/Tensor/None/Ellipsis/bool (#33528) * [cherry-pick 2.1] Polish code for _getitem_impl_ (#32868) * [cherry-pick] Polish code for setitem and getitem (#32911) * [slice getitem] Support getitem idx is Tensor or List (#33000) * [getitem] Support index is None for getitem in static mode (#33001) * [Static getitem] Support static Variable getitem for Ellipsis index (#32876) * [static getitem]Support index is list bool for getitem in static mode (#33298)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
As the title
For example: