Fix LayerNorm Problem #33420
Merged
Fix LayerNorm Problem #33420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
…hile large data input
jeff41404
reviewed
Jun 10, 2021
| @@ -952,7 +977,7 @@ class LayerNormGradKernel<platform::CUDADeviceContext, T> | |||
| const auto begin_norm_axis = ctx.Attr<int>("begin_norm_axis"); | |||
| auto matrix_dim = framework::flatten_to_2d(x_dims, begin_norm_axis); | |||
| int batch_size = static_cast<int>(matrix_dim[0]); | |||
There was a problem hiding this comment.
batch_size是否也需要改成 int64_t
ZHUI
reviewed
Jun 11, 2021
jeff41404
reviewed
Jun 11, 2021
| @@ -898,7 +923,7 @@ class LayerNormKernel<platform::CUDADeviceContext, T> | |||
|
|
|||
| auto matrix_dim = framework::flatten_to_2d(x_dims, begin_norm_axis); | |||
| int batch_size = static_cast<int>(matrix_dim[0]); | |||
There was a problem hiding this comment.
batch_size是否也需要改成 int64_t
jeff41404
reviewed
Jun 11, 2021
| @@ -952,7 +977,7 @@ class LayerNormGradKernel<platform::CUDADeviceContext, T> | |||
| const auto begin_norm_axis = ctx.Attr<int>("begin_norm_axis"); | |||
| auto matrix_dim = framework::flatten_to_2d(x_dims, begin_norm_axis); | |||
| int batch_size = static_cast<int>(matrix_dim[0]); | |||
| int feature_size = static_cast<int>(matrix_dim[1]); | |||
| int64_t feature_size = static_cast<int64_t>(matrix_dim[1]); | |||
|
|
|||
| LayerNormBackward<T, U>(x_data, d_y_data, scale_data, mean_data, var_data, | |||
There was a problem hiding this comment.
本次主要对正向计算进行了优化，反向计算的优化也可以在未来考虑
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
优化LayerNorm计算过程。
同时修复如下问题：
DLTP-25782 [Bug]
DLTP-26400 [Bug]
修复LayerNorm在大数输入时输出Nan的bug。
DLTP-28680 [Bug]
修复LayerNorm在归一化维度长度<kMaxBlockDim时的BlockDim计算错误bug。
修复LayerNorm在大输入shape时输出结果0的bug。