-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fc_elementwise_layer_fuse_pass #33467
fc_elementwise_layer_fuse_pass #33467
Conversation
Thanks for your contribution! |
… fc_elementwise_layernorm_pass
.AddAttr("in_num_col_dims") | ||
.IsNumGE(1) | ||
.End() | ||
.AddAttr("activation_type") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要补充 activation_type的判定条件
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
属性限定为relu或者为空
.End() | ||
.AddOutput("Out") | ||
.IsTensor() | ||
.End(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
缺了axis属性
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已经添加
.IsTensor() | ||
.End(); | ||
|
||
AddOpCompat(OpCompat("fused_fc_elementwise_layernorm")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不在@op_name@.pbtxt中的算子不需要进行兼容性检测
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已经删除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确认一下 element_wise的axis的约束条件
.AddOutput("Out") | ||
.IsTensor() | ||
.End() | ||
.AddAttr("axis") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请在确认一下axis的判断条件
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
axis确认是-1,已经修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
others
PR changes
others
Describe
fc_elementwise_layernorm_pass