Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fc_elementwise_layer_fuse_pass #33467

Merged
merged 5 commits into from
Jun 11, 2021
Merged

fc_elementwise_layer_fuse_pass #33467

merged 5 commits into from
Jun 11, 2021

Conversation

fengxiaoshuai
Copy link
Contributor

PR types

others

PR changes

others

Describe

fc_elementwise_layernorm_pass

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 9, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

.AddAttr("in_num_col_dims")
.IsNumGE(1)
.End()
.AddAttr("activation_type")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要补充 activation_type的判定条件

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

属性限定为relu或者为空

.End()
.AddOutput("Out")
.IsTensor()
.End();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺了axis属性

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经添加

.IsTensor()
.End();

AddOpCompat(OpCompat("fused_fc_elementwise_layernorm"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不在@op_name@.pbtxt中的算子不需要进行兼容性检测

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经删除

Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确认一下 element_wise的axis的约束条件

.AddOutput("Out")
.IsTensor()
.End()
.AddAttr("axis")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请在确认一下axis的判断条件

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

axis确认是-1,已经修改

Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shixiaowei02 Shixiaowei02 merged commit 9d8d531 into PaddlePaddle:develop Jun 11, 2021
@fengxiaoshuai fengxiaoshuai deleted the fc_elementwise_layernorm_pass branch July 1, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants