support python test without installation python package #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangliao
reviewed
Aug 9, 2017
cmake/generic.cmake
Outdated
| @@ -411,7 +411,7 @@ function(py_test TARGET_NAME) | |||
| set(multiValueArgs SRCS DEPS) | |||
| cmake_parse_arguments(py_test "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN}) | |||
| add_test(NAME ${TARGET_NAME} | |||
| COMMAND env PYTHONPATH=${PADDLE_PYTHON_PACKAGE_DIR} | |||
| COMMAND env PYTHONPATH=${PADDLE_PYTHON_LIB_DIR} | |||
There was a problem hiding this comment.
Did you test swig wrapper unit test??
There was a problem hiding this comment.
yes, I have run all the python test and I don't think that copy all the generated files to python src dir is a good idea.
There was a problem hiding this comment.
please pip uninstall paddlepaddle before you test this PR.
test 91
Start 91: testGradientMachine
91: Test command: /usr/bin/env "PYTHONPATH=" "python2" "testGradientMachine.py"
91: Test timeout computed to be: 9.99988e+06
91: Traceback (most recent call last):
91: File "testGradientMachine.py", line 15, in <module>
91: from py_paddle import swig_paddle
91: ImportError: No module named py_paddle
1/1 Test #91: testGradientMachine ..............***Failed 0.03 sec
0% tests passed, 1 tests failed out of 1
test 90
Start 90: testArguments
90: Test command: /usr/bin/env "PYTHONPATH=" "python2" "testArguments.py"
90: Test timeout computed to be: 9.99988e+06
90: Traceback (most recent call last):
90: File "testArguments.py", line 15, in <module>
90: from py_paddle import swig_paddle
90: ImportError: No module named py_paddle
1/1 Test #90: testArguments ....................***Failed 0.03 secThere was a problem hiding this comment.
copy Python proto into paddle/v2/framework/protois necessary. because we import proto like import paddle.v2.framework.proto in our code.
wangkuiyi
reviewed
Aug 10, 2017
There was a problem hiding this comment.
Thanks to @jacquesqiao and @gangliao for this PR and #3360!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3352
after
make, can useto run python unit test is build dir without install the python package.
tested on all python unit test.