Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPU] add NPU ops of stack and unstack, test=develop #34084

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

qili93
Copy link
Contributor

@qili93 qili93 commented Jul 11, 2021

PR types

New features

PR changes

OPs

Describe

(1) 新增了unstack, unstack_grad 和 stack_grad 三个 NPU OP Kernel,以及 test_unstack_op_npu.py 的单测
(2) 改动了 stack 的 NPU OP Kernel, 在 axis != 0 的情况下可以直接调用Pack, 不需要先Pack再Transpose,(原PR #31711)
(3) 增加了test_stack_op_npu.py里面的单测内容,保持单测与 test_stack_op.py一致,且单测通过
(4) PR 里面没有提,但是手动测试增加stack和unstack的C++单测,位于
- https://github.com/qili93/Paddle/blob/test_npu_stack/paddle/fluid/operators/stack_op_npu_test.cc
- https://github.com/qili93/Paddle/blob/test_npu_stack/paddle/fluid/operators/unstack_op_npu_test.cc

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@qili93 qili93 requested a review from zhiqiu July 11, 2021 11:23
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit 0b20b76 into PaddlePaddle:develop Jul 12, 2021
@qili93 qili93 deleted the add_stack_npu_op_dev branch July 12, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants