Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large model train doc #3445

Merged
merged 3 commits into from
Aug 15, 2017
Merged

Large model train doc #3445

merged 3 commits into from
Aug 15, 2017

Conversation

typhoonzero
Copy link
Contributor

Just some note.

jacquesqiao
jacquesqiao reviewed Aug 13, 2017
View reviewed changes
doc/design/cluster_train/large_model_dist_train.md Outdated
```c++
if (fullSize) {
...
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, remove space at the head of these line

jacquesqiao
jacquesqiao approved these changes Aug 15, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@typhoonzero typhoonzero merged commit d08550f into PaddlePaddle:develop Aug 15, 2017
@typhoonzero typhoonzero deleted the large_model_train_note branch December 22, 2017 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@typhoonzero @jacquesqiao