RNN backward create #3490
Merged
RNN backward create #3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rnn-backward-create
… rnn-backward-create
reyoung
reviewed
Aug 15, 2017
paddle/operators/recurrent_op.h
Outdated
| /* | ||
| * Some special preprocesses after a gradient op is created. | ||
| */ | ||
| static void Init(const RecurrentOp& op, RecurrentGradientOp* grad_op, |
There was a problem hiding this comment.
Init is a bad pattern, put Init() into the constructor.
reyoung
reviewed
Aug 15, 2017
paddle/operators/recurrent_op.cc
Outdated
| void RecurrentGradientOp::Init( | ||
| const RecurrentOp& op, RecurrentGradientOp* grad_op, | ||
| const std::unordered_set<std::string>& no_grad_vars) { | ||
| auto gradop = Backward(op.stepnet(), no_grad_vars); |
There was a problem hiding this comment.
如果是递归调用的话，需要调用的是 BackwardRecursive那个函数，而不是Backward函数，另外还有一些参数，比如uid之类的需要在递归中传递过去。
reyoung
reviewed
Aug 15, 2017
| @@ -178,11 +179,24 @@ std::shared_ptr<OperatorBase> BackwardRecursive( | |||
| return false; | |||
| }); | |||
|
|
|||
| // process recurrent gradient op as a special operator. | |||
| if (forwardOp.Type() == "recurrent_op") { | |||
| // NOTE clean up cycle call somewhere (RNN's stepnet constains itself), or | |||
There was a problem hiding this comment.
Just write create method here should be simplest.
reyoung
approved these changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #3472