Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CostInfo and MemProfiler in InterpreterCore #34981

Merged
merged 13 commits into from
Aug 31, 2021
Merged

Support CostInfo and MemProfiler in InterpreterCore #34981

merged 13 commits into from
Aug 31, 2021

Conversation

Aurelius84
Copy link
Contributor

@Aurelius84 Aurelius84 commented Aug 18, 2021 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

Support CostInfo in New Executor

Why modify into Atomic?

If you have a counter for which atomic operations are supported, it will be more efficient than a mutex.

  1. Atomic operations leverage processor support (compare and swap instructions) and don't use locks at all, whereas locks are more OS-dependent and perform differently on, for example, Win and Linux.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Aurelius84 Aurelius84 changed the title Support CostInfo in New Executor Support CostInfo and MemProfiler in InterpreterCore Aug 30, 2021
wanghuancoder
wanghuancoder approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 572bad8 into PaddlePaddle:develop Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoyulong aoyulong aoyulong left review comments

@wanghuancoder wanghuancoder wanghuancoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aurelius84 @aoyulong @wanghuancoder