Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the extra and quantization for op def. #35076

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

winter-wang
Copy link
Contributor

@winter-wang winter-wang commented Aug 23, 2021

PR types

New features

PR changes

Others

Describe

  1. 为op_def中的属性、输入、输出添加extra、quant标记,分别表示前向推理所必须的、量化推理时新增必须的字段。
  2. 在OpMaker中添加AsExtra()和AsQuant()的标记接口。
  3. 模型保存时会裁剪掉所有标记为extra的字段

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Shixiaowei02
Copy link
Contributor

考虑到 quant 属性可扩展性,是否有必要起一个涵盖面更广的名字?

Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winter-wang
Copy link
Contributor Author

考虑到 quant 属性可扩展性,是否有必要起一个涵盖面更广的名字?

我觉得还好,因为目前的设计,quant属性和extra属性的唯一区别就是在量化的时候,quant属性不会被裁剪。

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql
Copy link
Contributor

考虑到 quant 属性可扩展性,是否有必要起一个涵盖面更广的名字?

我觉得还好,因为目前的设计,quant属性和extra属性的唯一区别就是在量化的时候,quant属性不会被裁剪。

不太确定这个quant作为quantization的缩写是否合适,quant更多是用于金融领域的一个词,个人觉得这里沿袭之前的风格,像duplicable,intermediate,dispensable这种全拼命名比较好

@winter-wang winter-wang merged commit cb28753 into PaddlePaddle:develop Aug 24, 2021
@winter-wang
Copy link
Contributor Author

考虑到 quant 属性可扩展性,是否有必要起一个涵盖面更广的名字?

我觉得还好,因为目前的设计,quant属性和extra属性的唯一区别就是在量化的时候,quant属性不会被裁剪。

不太确定这个quant作为quantization的缩写是否合适,quant更多是用于金融领域的一个词,个人觉得这里沿袭之前的风格,像duplicable,intermediate,dispensable这种全拼命名比较好

之前考虑过沿袭之前的风格使用quantizable这个单词,但是感觉好像也不是很合适,quantizable意思是“可量化地”,但我们这儿的意思应该是“only used in quantization”,感觉意思还是有一些不同。用quantizaiton的话,这是一个名词,好像也不是很合适。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants