Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scope guard for better resource releasing #35103

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Add scope guard for better resource releasing #35103

merged 1 commit into from
Aug 24, 2021

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Aug 23, 2021

PR types

Others

PR changes

Others

Describe

Add scope_guard for better resource releasing.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@sneaxiy sneaxiy mentioned this pull request Aug 23, 2021
Merged
@sneaxiy sneaxiy requested a review from zhiqiu August 24, 2021 02:32
@sneaxiy sneaxiy changed the title Add scope guard Add scope guard for better resource releasing Aug 24, 2021
zhiqiu
zhiqiu approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit b0a1d12 into PaddlePaddle:develop Aug 24, 2021
@sneaxiy sneaxiy deleted the add_scope_guard branch August 24, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sneaxiy @zhiqiu