Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add copy from tensor" #35173

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Revert "Add copy from tensor" #35173

merged 1 commit into from
Aug 27, 2021

Conversation

lelelelelez
Copy link
Contributor

@lelelelelez lelelelelez commented Aug 26, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

Reverts #34406

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 26, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

shangzhizhou
shangzhizhou approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks

@wanghuancoder wanghuancoder merged commit 32c1ec4 into develop Aug 27, 2021
shangzhizhou added a commit to shangzhizhou/Paddle that referenced this pull request Aug 30, 2021
@shangzhizhou
Revert "Revert "Add copy from tensor (PaddlePaddle#34406)" (PaddlePad…
cea8154 
…dle#35173)"

This reverts commit 32c1ec4.
shangzhizhou added a commit that referenced this pull request Aug 31, 2021
@shangzhizhou
Revert "Revert "Add copy from tensor (#34406)" (#35173)" (#35256)
6116f9a 
* Revert "Revert "Add copy from tensor (#34406)" (#35173)"

This reverts commit 32c1ec4.

* add template instantiation
@lelelelelez lelelelelez deleted the revert-34406-add_copy_from_tensor branch September 17, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shangzhizhou shangzhizhou shangzhizhou approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@wanghuancoder wanghuancoder wanghuancoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lelelelelez @wanghuancoder @XieYunshen @shangzhizhou