Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug that cmake find python #35304

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Aug 31, 2021

PR types

Bug fixes

PR changes

Others

Describe

修改cmake判断是否找到Python环境的bug。

错误情况下的返回码,虽不为0,但可能包含0,例如9009。这里如果使用正则匹配,容易导致判断失误。
infoflow 2021-08-31 14-13-32

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 31, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 00c9aeb into PaddlePaddle:develop Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants