Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPU] set constant before copy data #35335

Merged

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Sep 1, 2021

PR types

Others

PR changes

Others

Describe

For NPU, the nan/inf check will check the operand for every operators. If the align parts of the coalesce tensor contain nan/inf, it will trigger the NPU's nan/inf check. This update is mainly for c_allreduce_sum fusion.

image

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 1, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@FeixLiu FeixLiu force-pushed the coalesce_copy_data_npu_update branch from 2b77c99 to 93985b1 Compare September 1, 2021 01:18
Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongweibao gongweibao merged commit bee511d into PaddlePaddle:develop Sep 1, 2021
@FeixLiu FeixLiu deleted the coalesce_copy_data_npu_update branch September 1, 2021 11:25
FeixLiu added a commit to FeixLiu/Paddle that referenced this pull request Sep 2, 2021
FeixLiu added a commit to FeixLiu/Paddle that referenced this pull request Sep 3, 2021
@FeixLiu FeixLiu mentioned this pull request Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants