Work queue group #35470
Work queue group #35470
Conversation
|
Thanks for your contribution! |
| @@ -157,7 +157,8 @@ InterpreterCore::InterpreterCore(const platform::Place& place, | |||
| garbages_.reset(new GarbageQueue()); | |||
| max_memory_size_ = static_cast<size_t>(GetEagerDeletionThreshold()); | |||
| cur_memory_size_ = 0; | |||
| gc_queue_ = CreateSingleThreadedWorkQueue(); | |||
| WorkQueueOptions options; | |||
There was a problem hiding this comment.
options不需要赋值吗？我看默认线程数是0。
| MultiThreadedWorkQueue(const MultiThreadedWorkQueue&) = delete; | ||
| void WorkQueueGroupImpl::AddTask(size_t queue_idx, std::function<void()> fn) { | ||
| assert(queue_idx < queues_.size()); | ||
| if (queues_options_[queue_idx].track_task) { |
There was a problem hiding this comment.
这里是不是可以直接 if(nullptr == track_task_) ?
这里是支持 queues_options_ 部分track_task 为False， 部分为true?
| MultiThreadedWorkQueue& operator=(const MultiThreadedWorkQueue&) = delete; | ||
| void WorkQueueGroupImpl::WaitQueueGroupEmpty() { | ||
| if (nullptr == tracker_) { | ||
| abort(); |
There was a problem hiding this comment.
如果tracker_为空，这里是不是给一些error信息，表示我们不支持在未指定track_task时，调用WaitQueueGroupEmpty接口，直接abort会让开发者很困惑？
| virtual ~MultiThreadedWorkQueue() = default; | ||
| size_t WorkQueueGroupImpl::QueueNumThreads(size_t queue_idx) const { | ||
| assert(queue_idx < queues_.size()); | ||
| return queues_[queue_idx]->NumThreads(); |
There was a problem hiding this comment.
Release版本不会执行执行assert，这里会存在越界风险，添加检查或者改为 queues_.at(queue_idx)
| struct WorkQueueOptions { | ||
| size_t num_threads{0}; | ||
| bool allow_spinning{true}; | ||
| bool track_task{false}; |
There was a problem hiding this comment.
这里是否提供一个有参构造函数比较好一些？track_task参数比较容易被误用。
”条款18：让接口容易被正确使用，不易被误用“ —— 《Effective C++ 》
There was a problem hiding this comment.
这个options会扩充，提供了默认值。但是不提供构造函数，因为构造函数的参数中万一错位，很麻烦，必须显示使用一行代码修改不想要默认值的选项
* Split Tracker and WorkQueue * add WorkQueueGroup * add unittest * fix * update * update * fix compile
* Split Tracker and WorkQueue * add WorkQueueGroup * add unittest * fix * update * update * fix compile
PR types
New features
PR changes
Others
Describe
Add WorkQueueGroup type，multi Queue as a whole to WaitEmpty