Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oneDNN] candidate fix to #34554 #35884

Merged
merged 5 commits into from
Sep 24, 2021
Merged

[oneDNN] candidate fix to #34554 #35884

merged 5 commits into from
Sep 24, 2021

Conversation

jczaja
Copy link
Contributor

@jczaja jczaja commented Sep 20, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

This is another fix to have issue #34554 resolved.

@jczaja jczaja added the Intel label Sep 20, 2021
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jczaja jczaja changed the title [WIP] candidate fix to #34554 [oneDNN] candidate fix to #34554 Sep 21, 2021
jakpiase
jakpiase previously approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lidanqing-intel
lidanqing-intel previously approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase jakpiase self-requested a review September 23, 2021 13:05
jakpiase
jakpiase approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja mentioned this pull request Sep 23, 2021
Closed
lidanqing-intel
lidanqing-intel approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the title so that the title could be collected directly by github cli for release note without any changes. Thanks

LGTM.

@jczaja jczaja merged commit 485b387 into PaddlePaddle:develop Sep 24, 2021
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
@jczaja @AnnaTrainingG
[oneDNN] candidate fix to PaddlePaddle#34554 (PaddlePaddle#35884)
3b17cb2 
* - candidate fix

* - More fixes to PaddlePaddle#34554

* - another incosnstent fix to key

* - Remvoed unneeded line

* - matching the cache behaviour to other ops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakpiase jakpiase jakpiase approved these changes

@lidanqing-intel lidanqing-intel lidanqing-intel approved these changes

Assignees
No one assigned
Labels
Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jczaja @lidanqing-intel @jakpiase