op:transpose_op supports bool type #35886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR's description meets the template requirements! |
|
Thanks for your contribution! |
TCChenlong
approved these changes
Sep 22, 2021
Superjomn
reviewed
Sep 22, 2021
| x1 = fluid.layers.data( | ||
| name='x1', shape=[10, 5, 3], dtype='bool') | ||
| name='x1', shape=[10, 5, 3], dtype='int8') |
There was a problem hiding this comment.
这里为啥把 bool 改为 int8 ?
bool 不是新增吗？
There was a problem hiding this comment.
这个测试case是TestTransposeOpError，验证不支持的输入类型。即，在不支持bool输入时，设置bool报错，即验证不支持该类型。
现在已经支持bool类型，要修改为不支持的类型，目前不支持int8，所以设置int8
TeslaZhao
commented
Sep 22, 2021
| x1 = fluid.layers.data( | ||
| name='x1', shape=[10, 5, 3], dtype='bool') | ||
| name='x1', shape=[10, 5, 3], dtype='int8') |
There was a problem hiding this comment.
这个测试case是TestTransposeOpError，验证不支持的输入类型。即，在不支持bool输入时，设置bool报错，即验证不支持该类型。
现在已经支持bool类型，要修改为不支持的类型，目前不支持int8，所以设置int8
TeslaZhao
added a commit
to TeslaZhao/Paddle
that referenced
this pull request
Sep 22, 2021
* Pass compat of conv_transpose_bias_mkldnn_fuse_pass * Fix a bug of strided_slice op, about the axes parameter access memory out of bounds * Fix a bug of transpose op, about accessing memory out of bounds of the perm param * op:transpose_op supports bool type
Superjomn
pushed a commit
that referenced
this pull request
Sep 23, 2021
* Pass compat of conv_transpose_bias_mkldnn_fuse_pass * Fix a bug of strided_slice op, about the axes parameter access memory out of bounds * Fix a bug of transpose op, about accessing memory out of bounds of the perm param * op:transpose_op supports bool type
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* Pass compat of conv_transpose_bias_mkldnn_fuse_pass * Fix a bug of strided_slice op, about the axes parameter access memory out of bounds * Fix a bug of transpose op, about accessing memory out of bounds of the perm param * op:transpose_op supports bool type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
transpose_op supports bool type input & output