Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added concat BF16/FP32 BWD OneDNN kernel #35889

Merged
merged 11 commits into from
Oct 5, 2021

Conversation

jakpiase
Copy link
Contributor

PR types

New features

PR changes

OPs

Describe

Added concat BF16/FP32 BWD OneDNN kernel. I have also done some refactoring with concat tests

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@lidanqing-intel
Copy link
Contributor

lidanqing-intel commented Sep 21, 2021

@lidanqing-intel @wzzju Hi, this PR need approval. Since now concat grad fp32/bf16 op is added, some UT could be combined together.

Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jczaja
jczaja previously approved these changes Sep 21, 2021
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wzzju
wzzju previously approved these changes Sep 27, 2021
Copy link
Contributor

@wzzju wzzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase jakpiase dismissed stale reviews from wzzju, jczaja, and lidanqing-intel via 47a73fe October 4, 2021 16:22
@jczaja jczaja merged commit dc4d571 into PaddlePaddle:develop Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants