Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PaddlePaddle Hackathon] add AlexNet #36058

Merged
merged 19 commits into from
Oct 13, 2021
Merged

[PaddlePaddle Hackathon] add AlexNet #36058

merged 19 commits into from
Oct 13, 2021

Conversation

fuqianya
Copy link
Contributor

@fuqianya fuqianya commented Sep 24, 2021 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

Add AlexNet to Paddle Vision (include calling of higher-level api, test case and doc).
Doc is at PaddlePaddle/docs#3918.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@fuqianya fuqianya mentioned this pull request Sep 24, 2021
Closed
@LielinJiang
Copy link
Contributor

LielinJiang commented Sep 27, 2021 •
edited
Loading

https://github.com/PaddlePaddle/Paddle/pull/36058/files#diff-5279997c80a9e46dd9b23b5b6f3a72cfba89e134c50428d14b5f7bb86bd0ec75R61
这样的命名方式会造成一个程序中调用两次而报错，建议所有的队伍去除命名，同时调整原有的clas权重名字。
同时需要补充一个自测，精度是否对齐，可以借助PaddleClas

@fuqianya
Copy link
Contributor Author

@LielinJiang 您好，感谢您的解答！请问 “补充一个自测，精度是否对齐”是指要在分类数据集检查精度是否对齐吗？还是只要固定一个输入，检查输出是否对齐？

@LielinJiang
Copy link
Contributor

LielinJiang commented Sep 27, 2021 •
edited
Loading

@LielinJiang 您好，感谢您的解答！请问 “补充一个自测，精度是否对齐”是指要在分类数据集检查精度是否对齐吗？还是只要固定一个输入，检查输出是否对齐？

是指在分类的数据集对齐，自测精度和clas的精度对齐

@fuqianya
Copy link
Contributor Author

好的，谢谢 ！

@SigureMo
Copy link
Member

同时调整原有的clas权重名字。

@LielinJiang 我们刚刚测试删除命名已经可以导入 clas 权重，请问还需要调整 clas 权重名字吗，这个调整 clas 权重名字是指我们把新的以动态图方式命名的权重导出后放到云盘之类的地方发送给你们以供部署的意思吗？

@LielinJiang
Copy link
Contributor

同时调整原有的clas权重名字。

@LielinJiang 我们刚刚测试删除命名已经可以导入 clas 权重，请问还需要调整 clas 权重名字吗，这个调整 clas 权重名字是指我们把新的以动态图方式命名的权重导出后放到云盘之类的地方发送给你们以供部署的意思吗？

需要看一下是否有warning，说某些参数没找到，并且自测一下精度是否达标。按道理删除命名，是无法正确加载权重的

@SigureMo
Copy link
Member

同时调整原有的clas权重名字。

@LielinJiang 我们刚刚测试删除命名已经可以导入 clas 权重，请问还需要调整 clas 权重名字吗，这个调整 clas 权重名字是指我们把新的以动态图方式命名的权重导出后放到云盘之类的地方发送给你们以供部署的意思吗？

需要看一下是否有warning，说某些参数没找到，并且自测一下精度是否达标。按道理删除命名，是无法正确加载权重的

嗯嗯，感谢，我们去试试～～～

@fuqianya fuqianya changed the title add alexnet [PaddlePaddle Hackathon] add AlexNet Sep 28, 2021
@fuqianya
Copy link
Contributor Author

@LielinJiang 能帮忙review一下嘛

@fuqianya
Copy link
Contributor Author

谢谢啦

TCChenlong
TCChenlong approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LielinJiang
Copy link
Contributor

https://github.com/PaddlePaddle/Paddle/pull/36070，参考这个PR，补充一个自测把

@fuqianya
Copy link
Contributor Author

https://github.com/PaddlePaddle/Paddle/pull/36070，参考这个PR，补充一个自测把

老师，已经自测过了，结果放在了这里。

XiaoguangHu01
XiaoguangHu01 approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LielinJiang LielinJiang merged commit caa2003 into PaddlePaddle:develop Oct 13, 2021
@fuqianya fuqianya deleted the add-AlexNet branch October 13, 2021 05:59
@TCChenlong TCChenlong mentioned this pull request Mar 8, 2022
Closed
@luotao1 luotao1 mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LielinJiang LielinJiang LielinJiang approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fuqianya @LielinJiang @SigureMo @TCChenlong @XiaoguangHu01