Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wait if no fetch data in PE #36150

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Remove wait if no fetch data in PE #36150

merged 1 commit into from
Sep 29, 2021

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Sep 27, 2021 •
edited
Loading

PR types

Performance optimization

PR changes

Others

Describe

Remove device context wait if there is no fetch data in ParallelExecutor.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Sep 27, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Sep 27, 2021
chenwhql
chenwhql approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit b3d2dc7 into PaddlePaddle:develop Sep 29, 2021
@sneaxiy sneaxiy deleted the remove_wait_if_no_fetch branch September 29, 2021 02:36
@sneaxiy sneaxiy mentioned this pull request Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenwhql chenwhql chenwhql approved these changes

@Xreki Xreki Awaiting requested review from Xreki

@zhiqiu zhiqiu Awaiting requested review from zhiqiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sneaxiy @chenwhql