add ctr table depends #36465
Merged
add ctr table depends #36465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for your contribution! |
zhaocaibei123
force-pushed
the
accessor_20211015
branch
from
66f94aa
to
944a5f6
Compare
chenwhql
reviewed
Oct 15, 2021
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #ifndef PADDLE_FLUID_DISTRIBUTED_COMMON_LOCAL_RANDOM_H_ |
There was a problem hiding this comment.
recommend using #pragma once
| namespace distributed { | ||
|
|
||
| // Get time in seconds. | ||
| inline double current_realtime() { |
| size_t beta2_pow_index() { return beta1_pow_index() + 1; } | ||
|
|
||
| protected: | ||
| float _learning_rate; |
| @@ -0,0 +1,167 @@ | |||
| // Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved. | |||
|
|
||
| public: | ||
| map_type values_[CTR_SPARSE_SHARD_BUCKET_NUM]; | ||
| std::hash<uint64_t> _hasher; |
| @@ -31,8 +31,9 @@ struct PullSparseValue { | |||
| feasigns_(nullptr), | |||
| frequencies_(nullptr) {} | |||
|
|
|||
| explicit PullSparseValue(std::vector<uint64_t> feasigns, | |||
| std::vector<uint32_t> frequencies, int dim) { | |||
| explicit PullSparseValue(std::vector<uint64_t>& feasigns, // NOLINT | |||
There was a problem hiding this comment.
why use nolint? can we use const& here?
| @@ -0,0 +1,55 @@ | |||
| /* Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved. | |||
|
|
||
| auto* feature_value = shard->Init(key); | ||
| feature_value->resize(vec.size()); | ||
| memcpy(const_cast<float*>(feature_value->data()), vec.data(), |
There was a problem hiding this comment.
看起来好像feature_value->data()并不是const的？
| @@ -0,0 +1,183 @@ | |||
| /*************************************************************************** | |||
zhaocaibei123
force-pushed
the
accessor_20211015
branch
from
8871af8
to
5fc488c
Compare
zhaocaibei123
force-pushed
the
accessor_20211015
branch
from
eb49f85
to
abd3282
Compare
fuyinno4
reviewed
Oct 18, 2021
paddle/fluid/distributed/ps.proto
Outdated
| optional uint32 fea_dim = 4 [ default = 11 ]; | ||
| optional uint32 embedx_dim = 5 [ default = 8 ]; | ||
| optional uint32 embedx_threshold = 6 [ default = 10 ]; | ||
| optional DownpourTableAccessorParameter downpour_accessor_param = 7; |
paddle/fluid/distributed/ps.proto
Outdated
| repeated float weight_bounds = 4; | ||
| } | ||
|
|
||
| message SparseAdamSGDParameter { |
| namespace paddle { | ||
| namespace distributed { | ||
|
|
||
| void CtrSparseNaiveSGDRule::load_config( |
There was a problem hiding this comment.
去掉ctr，另外是和proto保持一致；proto里面添加注释
paddle/fluid/distributed/ps.proto
Outdated
| @@ -150,3 +181,39 @@ message TableAccessorSaveParameter { | |||
| optional string converter = 2; | |||
| optional string deconverter = 3; | |||
| } | |||
|
|
|||
| message SparseSGDRuleParameter { | |||
| std::vector<float> data_; | ||
| }; | ||
|
|
||
| class CtrValueBlock { |
zhaocaibei123
force-pushed
the
accessor_20211015
branch
from
176b8f3
to
d7ee7f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
add memory sparse table dependency: