[Auto Parallel] Completion Dist Attribute for Backward & Update stage #36744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
✅ This PR's description meets the template requirements! |
Caozhou1995
reviewed
Oct 27, 2021
| output_var_attr = TensorDistributedAttribute(output_var, | ||
| dist_context) | ||
| output_var_attr.set_dims_mapping(ref_dims_mapping) | ||
| output_var_attr.set_process_mesh(ref_process_mesh) |
There was a problem hiding this comment.
the grad var process mesh should be the same with grad op instead of forward var?
There was a problem hiding this comment.
yes， here is a bug and had been fixed
aoyulong
reviewed
Oct 27, 2021
wangxicoding
approved these changes
Oct 27, 2021
| # var | ||
| for output_name in grad_op.desc.output_names(): | ||
| assert len(grad_op.desc.output(output_name)) in [0, 1] | ||
| # if grad_op.type == "cast": |
ghost
pushed a commit
to piotrekobi/Paddle
that referenced
this pull request
Nov 3, 2021
…PaddlePaddle#36744) * revise completion for backward * revise completion for update * revise completion for update * update unitest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
Completion Dist Attribute for Backward & Update stage
Make sure all op and var have Dist Attribute