Add Support for OperatorBase in new executor #36945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Aurelius84
reviewed
Nov 5, 2021
| if (op_with_kernel == nullptr) | ||
| instr_node.OpBase()->Run(*global_scope_->GetScope(), place_); | ||
| else | ||
| instr_node.KernelFunc()(*instr_node.InnerExecutionContext().get()); |
There was a problem hiding this comment.
下个PR，这里的KernelFunc可以抽象为一个单独的类，里面处理OperatorBase和OperatorWithKernel 的分支，对外只暴露Run接口
| // ScopeBase. | ||
| // Scope manager the variables and VariableScope is just a | ||
| // quick | ||
| // access machanism. |
There was a problem hiding this comment.
下个PR，考虑是把ScopeBase去掉，或者有个单独的子类继承ScopeBase，然后VariableScope持有这个子类对象？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Add Support for OperatorBase in new executor.