[fleet_executor] Parse pipeline config #37319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
LiYuRio
reviewed
Nov 18, 2021
LiYuRio
reviewed
Nov 18, 2021
| @@ -27,4 +27,6 @@ message FleetExecutorDesc { | |||
| optional int32 dp_degree = 4 [ default = 1 ]; | |||
| optional int32 mp_degree = 5 [ default = 1 ]; | |||
| optional int32 pp_degree = 6 [ default = 1 ]; | |||
| optional int64 num_micro_batches = 7 [ default = 1 ]; | |||
There was a problem hiding this comment.
这个在python端就是global batch size / micro batch size，所以叫num_mircro_batches？一共有多少个mirco batch？其实就是num_micro_steps
| @@ -27,4 +27,6 @@ message FleetExecutorDesc { | |||
| optional int32 dp_degree = 4 [ default = 1 ]; | |||
| optional int32 mp_degree = 5 [ default = 1 ]; | |||
| optional int32 pp_degree = 6 [ default = 1 ]; | |||
| optional int64 num_micro_batches = 7 [ default = 1 ]; | |||
| optional int64 num_slots = 8 [ default = 1 ]; | |||
| @@ -96,6 +96,9 @@ class Interceptor { | |||
| // local mailbox, written by FetchRemoteMailbox() | |||
| // read by PoolTheMailbox() | |||
| std::queue<InterceptorMessage> local_mailbox_; | |||
|
|
|||
| int64_t already_run_times_{0}; | |||
There was a problem hiding this comment.
这个建议加到后面的compute_interceptor中
There was a problem hiding this comment.
这个是为了fake run准备的，留着吧，后面的子类可以不用？
| if (role_to_ops.find(role_id) == role_to_ops.end()) { | ||
| task_nodes_.emplace_back( | ||
| TaskNode::CreateEmptyTaskNode(role_id, cur_rank, task_id)); | ||
| task_nodes_.emplace_back(TaskNode::CreateEmptyTaskNode( |
There was a problem hiding this comment.
后续可能需要有ComputeTaskNode
There was a problem hiding this comment.
没理解，为啥要单搞一个新的tasknode出来？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
parse pipeline config.