Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eager] Supported Eager Dygraph Forward & AutoGrad functions #37323

Merged
merged 13 commits into from
Nov 26, 2021

Conversation

jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented Nov 18, 2021

PR types

New features

PR changes

Others

Describe

This patch includes:

  1. Forward Dygraph API for scale
  2. Backward GradNode for scale
  3. global_utils
  4. tests

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 18, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jim19930609
Copy link
Contributor Author

@JiabinYang

}
}

void ScaleAPI(const egr::EagerTensor& x, float scale, float bias,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eager API 后续这块计划是怎样的?暂时均以手写封装推进吗?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还是说在pten api解决目前的性能问题之前,均会以这种方式独立编写?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有,这里主要是因为之前所有测试都是以Scale为基础写的,但是Pten暂时没迁Scale
如果后面Scale迁移了我会替换成Pten版的

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang merged commit 04e3b62 into PaddlePaddle:develop Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants