[Pten]Support parse kernel key by multi-inputs #37517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Shixiaowei02
previously approved these changes
Nov 25, 2021
zyfncg
reviewed
Nov 25, 2021
paddle/pten/api/lib/data_type_set.h
Outdated
Comment on lines
80
to
82
| } else if ((dtype_set.bitset() & f8) == f8) { | ||
| promote_type = DataType::FLOAT64; | ||
| } |
There was a problem hiding this comment.
注释里说这个函数是处理复数类型的，这里对float64的处理是为了？
chenwhql
reviewed
Nov 25, 2021
| @@ -51,6 +52,8 @@ struct KernelKeySet { | |||
| BackendSet backend_set{Backend::UNDEFINED}; | |||
| DataLayout layout{DataLayout::UNDEFINED}; | |||
| DataType dtype{DataType::UNDEFINED}; | |||
There was a problem hiding this comment.
dtype和dtype set设计上能否仅保留其一，比如在最终取回kernel key的时候，根据dtype set计算dtype，目前看起来有些冗余
There was a problem hiding this comment.
由于dtype自己的特性需要都保留，不过已优化了代码，看起来更好一些
zyfncg
approved these changes
Nov 26, 2021
Zjq9409
pushed a commit
to Zjq9409/Paddle
that referenced
this pull request
Dec 10, 2021
* Support parse kernel key by multi-inputs * optimize code according to reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Support parse kernel key by multi-inputs and the final kernel key's dtype will be determined by multi-inputs' dtype