-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet Executor] Refine runtime graph #37703
[Fleet Executor] Refine runtime graph #37703
Conversation
Thanks for your contribution! |
57295d7
to
00bfda8
Compare
00bfda8
to
cb40471
Compare
cb40471
to
e522e47
Compare
e522e47
to
fc983c2
Compare
8ff64f9
to
5063d5b
Compare
@@ -100,11 +100,25 @@ std::vector<OpRole> RuntimeGraph::functionality_order = { | |||
RuntimeGraph::RuntimeGraph(const ProgramDesc& program, | |||
const FleetExecutorDesc& exe_desc) | |||
: exe_desc_(exe_desc) { | |||
if (exe_desc.grain() == "coarse") { | |||
if (exe_desc.strategy() == "1F1B") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉可以根据pp的degree来判断,以后可以只要1F1B,不要FThenB。可以以后慢慢完善,gradient merge之类的也可以加
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好
@@ -682,6 +682,8 @@ def __init__(self, place=None): | |||
self._enable_interpreter_core = _is_enable_standalone_executor() | |||
self._executor_cache = _ExecutorCache(self.place) | |||
|
|||
self._fleet_executor_cache = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
之后还是改成program_caches、ctc_caches吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe
RuntimeGraph支持测试不切分program和按功能切分program