Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fleet_executor] Add amplify interceptor info runtime graph #37783

Merged
merged 13 commits into from
Dec 2, 2021

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Dec 2, 2021

PR types

Others

PR changes

Others

Describe

prepare for the PP 1F1B run.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 2, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

wangxicoding
wangxicoding previously approved these changes Dec 2, 2021
Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paddle/fluid/distributed/fleet_executor/runtime_graph.cc Outdated Show resolved Hide resolved
paddle/fluid/distributed/fleet_executor/runtime_graph.cc Outdated Show resolved Hide resolved
@FeixLiu FeixLiu force-pushed the add_type_info_for_runtime_graph branch from 0564c36 to 642e8f0 Compare December 2, 2021 07:47
@FeixLiu FeixLiu force-pushed the add_type_info_for_runtime_graph branch from 11fd2e7 to 5c4b91b Compare December 2, 2021 08:05
@@ -199,6 +199,13 @@ void Carrier::CreateInterceptors() {
int64_t interceptor_id = item.first;
TaskNode* task_node = item.second;

PADDLE_ENFORCE_LT(
task_node->run_at_offset(), task_node->run_per_steps(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amplifier才需要这个判断吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非amplifier的话,这个也不会又问题呀,初始值是对的

paddle/fluid/distributed/fleet_executor/task_node.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeixLiu FeixLiu merged commit f306965 into PaddlePaddle:develop Dec 2, 2021
@FeixLiu FeixLiu deleted the add_type_info_for_runtime_graph branch December 2, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants