-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unify Tensors PR #2] Replaced pten::LoD with paddle::framework::LoD #38275
Merged
jim19930609
merged 6 commits into
PaddlePaddle:develop
from
jim19930609:storage_allocation_pr
Dec 26, 2021
Merged
[Unify Tensors PR #2] Replaced pten::LoD with paddle::framework::LoD #38275
jim19930609
merged 6 commits into
PaddlePaddle:develop
from
jim19930609:storage_allocation_pr
Dec 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
jim19930609
changed the title
[Tensor Unification PR #2] Replaced pten::LoD with paddle::framework::LoD
[Unify Tensor PR #2] Replaced pten::LoD with paddle::framework::LoD
Dec 20, 2021
jim19930609
changed the title
[Unify Tensor PR #2] Replaced pten::LoD with paddle::framework::LoD
[Unify Tensors PR #2] Replaced pten::LoD with paddle::framework::LoD
Dec 20, 2021
… storage_allocation_pr
jim19930609
force-pushed
the
storage_allocation_pr
branch
from
December 21, 2021 03:17
065dd6e
to
bb63571
Compare
… storage_allocation_pr
jim19930609
force-pushed
the
storage_allocation_pr
branch
from
December 22, 2021 07:13
6cbbca4
to
a2df45e
Compare
@@ -261,6 +261,7 @@ class Vector { | |||
} | |||
|
|||
void CopyCPUDataToCUDA(const platform::Place &place) const { | |||
#if defined(PADDLE_WITH_CUDA) || defined(PADDLE_WITH_HIP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议 #elif 分支抛异常
jim19930609
force-pushed
the
storage_allocation_pr
branch
from
December 23, 2021 09:44
1ef45da
to
3c895b1
Compare
… storage_allocation_pr
Shixiaowei02
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
The original paddle::framework::LoD is designed way more complex than the current pten::LoD. Therefore we temporarily rollbacked pten::LoD to paddle::framework::LoD, so as to facilitate the progress of Tensor unification.