Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unify Tensors PR #2] Replaced pten::LoD with paddle::framework::LoD #38275

Merged
merged 6 commits into from
Dec 26, 2021

Conversation

jim19930609
Copy link
Contributor

PR types

New features

PR changes

Others

Describe

The original paddle::framework::LoD is designed way more complex than the current pten::LoD. Therefore we temporarily rollbacked pten::LoD to paddle::framework::LoD, so as to facilitate the progress of Tensor unification.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jim19930609 jim19930609 changed the title [Tensor Unification PR #2] Replaced pten::LoD with paddle::framework::LoD [Unify Tensor PR #2] Replaced pten::LoD with paddle::framework::LoD Dec 20, 2021
@jim19930609 jim19930609 changed the title [Unify Tensor PR #2] Replaced pten::LoD with paddle::framework::LoD [Unify Tensors PR #2] Replaced pten::LoD with paddle::framework::LoD Dec 20, 2021
@@ -261,6 +261,7 @@ class Vector {
}

void CopyCPUDataToCUDA(const platform::Place &place) const {
#if defined(PADDLE_WITH_CUDA) || defined(PADDLE_WITH_HIP)
Copy link
Contributor

@Shixiaowei02 Shixiaowei02 Dec 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议 #elif 分支抛异常

@jim19930609 jim19930609 merged commit bbe879f into PaddlePaddle:develop Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants