Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi tensor momentum regular bug #38344

Merged

Conversation

zhangbo9674
Copy link
Contributor

@zhangbo9674 zhangbo9674 commented Dec 22, 2021

PR types

Bug fixes

PR changes

APIs

Describe

修改multi tensor策略下momentum优化器参数regularizer属性为None时的逻辑错误。

  • 问题:
    如果momentum优化器初始化时设置了weight_decay属性,当parameter的regluarizer属性为None的时候,regularization_method和regularization_coeff将采用weight_decay属性,但错误的设置为了""和0.0

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangbo9674 zhangbo9674 merged commit bf6d65f into PaddlePaddle:develop Dec 22, 2021
zmxdream pushed a commit to zmxdream/Paddle that referenced this pull request Dec 25, 2021
* fix merged_momentum regular bug

* fix bug
@zhangbo9674 zhangbo9674 deleted the debug/fix_mt_moment_regular branch March 2, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants