Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize nearest_interp forward #38528

Merged
merged 38 commits into from
Jan 25, 2022
Merged

Optimize nearest_interp forward #38528

merged 38 commits into from
Jan 25, 2022

Conversation

AshburnLee
Copy link
Contributor

@AshburnLee AshburnLee commented Dec 28, 2021 •
edited
Loading

PR types

Performance optimization

PR changes

OPs

Describe

功能

优化了nearest_interp 算子的的前向计算

最终效果

截屏2022-01-21 10 04 29

效果：超越竞品，远超paddle-dev

@AshburnLee
Merge pull request #1 from PaddlePaddle/develop
8f532b0 
Update forked PaddlePaddle
@AshburnLee
Merge pull request #2 from PaddlePaddle/develop
5b5804d 
Update my fork
@AshburnLee
Merge pull request #3 from PaddlePaddle/develop
cee2470 
update from PaddlePaddle
@AshburnLee
Merge pull request #4 from PaddlePaddle/develop
5be3a45 
Update forked paddle repo
@AshburnLee
Merge pull request #5 from PaddlePaddle/develop
a1d92b7 
Update USERNAME/paddle
@AshburnLee
Merge pull request #6 from PaddlePaddle/develop
e674a5d 
update Paddle USERNAME repo
@AshburnLee
Merge pull request #7 from PaddlePaddle/develop
855d00b 
update username repo
@AshburnLee
Merge pull request #8 from PaddlePaddle/develop
7cb2c97 
update local paddlepaddle
@AshburnLee
Merge pull request #9 from PaddlePaddle/develop
db9fc91 
update paddlepaddle
@AshburnLee
Merge branch 'develop' of https://github.com/PaddlePaddle/paddle into…
c7b68c8 
… develop
@AshburnLee
Merge branch 'PaddlePaddle:develop' into develop
0fd630e
@AshburnLee
Merge branch 'PaddlePaddle:develop' into develop
4bbb33b
@AshburnLee
Merge branch 'PaddlePaddle:develop' into develop
30a1a89
@AshburnLee
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
ce3deec 
… develop
@AshburnLee
init commit
8c3620b
@AshburnLee
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
5719490 
… nearest_interp
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jan 5, 2022

Sorry to inform you that b7fd119's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@AshburnLee
Copy link
Contributor Author

已将FastDivMod 的初始化从GPU端移到CPU端

@JamesLim-sy
Copy link
Contributor

已将FastDivMod 的初始化从GPU端移到CPU端

需要贴一下修改后的性能数据

@AshburnLee
Copy link
Contributor Author

已将FastDivMod 的初始化从GPU端移到CPU端

需要贴一下修改后的性能数据

Done，见PR 描述

AshburnLee
AshburnLee commented Jan 12, 2022
View reviewed changes
Copy link
Contributor Author

@AshburnLee AshburnLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对于nchw，PR提供更快的3D kernel；对于nhwc，PR使用快速除法优化已有的1D kernel

paddle/fluid/operators/interpolate_v2_op.cu Outdated Show resolved Hide resolved
paddle/fluid/operators/interpolate_v2_op.cu Outdated Show resolved Hide resolved
ZzSean
ZzSean reviewed Jan 19, 2022
View reviewed changes
paddle/fluid/operators/interpolate_v2_op.cu Outdated Show resolved Hide resolved
paddle/fluid/operators/interpolate_v2_op.cu Outdated Show resolved Hide resolved
paddle/fluid/operators/interpolate_v2_op.cu Outdated Show resolved Hide resolved
paddle/fluid/platform/device/gpu/gpu_launch_config.h Outdated Show resolved Hide resolved
paddle/fluid/platform/device/gpu/gpu_launch_config.h Outdated Show resolved Hide resolved
@AshburnLee AshburnLee mentioned this pull request Jan 20, 2022
Merged
JamesLim-sy
JamesLim-sy approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@JamesLim-sy JamesLim-sy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，3D卷积的操作比较新颖，而且性能水平相比1D的提升更明显，整理一下这次优化的材料，组内做一个分享吧

ZzSean
ZzSean approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZzSean ZzSean merged commit 232bbce into PaddlePaddle:develop Jan 25, 2022
@AshburnLee AshburnLee deleted the nearest_interp branch January 25, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xreki Xreki Xreki left review comments

@JamesLim-sy JamesLim-sy JamesLim-sy approved these changes

@ZzSean ZzSean ZzSean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AshburnLee @JamesLim-sy @Xreki @ZzSean