Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mish FP32/BF16 kernel, conv and fc fuse passes #38623

Merged
merged 19 commits into from
Jan 18, 2022
Merged

Mish FP32/BF16 kernel, conv and fc fuse passes #38623

merged 19 commits into from
Jan 18, 2022

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Dec 30, 2021 •
edited
Loading

PR types

New Features

PR changes

OPs

Describe

  • Implemented Mish FP32/BF16 activation kernel,
  • Added Mish fuse pass for conv and fc operators,
  • Added 4 related unit tests.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jan 7, 2022

Sorry to inform you that 8a6c259's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@jczaja jczaja self-requested a review January 10, 2022 09:41
@Silv3S
Copy link
Member Author

Silv3S commented Jan 12, 2022

@jakpiase @jczaja please review

@jakpiase
Copy link
Contributor

Hi @Silv3S, please fix CI errors before review

jczaja
jczaja approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja requested a review from jakpiase January 13, 2022 09:59
jakpiase
jakpiase approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really good job!

@Silv3S
Copy link
Member Author

Silv3S commented Jan 13, 2022

Hello @Aganlengzi, could you review?

Aganlengzi
Aganlengzi approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@Aganlengzi Aganlengzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aganlengzi Aganlengzi merged commit 1d18bc2 into PaddlePaddle:develop Jan 18, 2022
@Silv3S Silv3S deleted the mish branch January 18, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aganlengzi Aganlengzi Aganlengzi approved these changes

@jczaja jczaja jczaja approved these changes

@jakpiase jakpiase jakpiase approved these changes

Assignees

@Aganlengzi Aganlengzi

Labels
BF16 Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Silv3S @jakpiase @Aganlengzi @jczaja