Add MaxUnPool3D op and MaxUnPool1D op #38716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
andyjiang1116
changed the title
tink2123
reviewed
Jan 7, 2022
| # use 2d to implenment 1d should expand padding in advance. | ||
| padding = _expand_low_nd_padding(padding) | ||
|
|
||
| if data_format not in ["NCHW"]: |
There was a problem hiding this comment.
这个判断没有意义，建议判断是否是NCL，然后再转换成NCHW
|
use composition of unpool2d、squeeze and unsqueeze to implement unpool1d, better to test performance. |
I have test 10000 times for paddle and torch, the results is 0.000104s(paddle) vs 0.003229s(torch), so |
raindrops2sea
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Add MaxUnPool3D op and MaxUnPool1D op.
MaxUnPool3D op:
MaxUnPool1D op: