[PSLIB] Add Metrics Module, Support User-defined Add Metric #38789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
… dev_add_metrics_module
ziyoujiyi
reviewed
Jan 17, 2022
| if (!this->merge_by_insid_) { | ||
| return fleet_ptr->LocalRandomEngine()() % this->trainer_num_; | ||
| } else { | ||
| if (this->merge_by_insid_) { | ||
| return XXH64(data.ins_id_.data(), data.ins_id_.length(), 0) % |
There was a problem hiding this comment.
- 此处 globalshuffle 在二次开发时需要新增 if/else，建议按照 neg sampling #36564 方法重构；
- 类、函数、变量命名按统一ps规范来 https://ku.baidu-int.com/knowledge/HFVrC7hq1Q/pKzJfZczuc/UQuex_mf2m/sTOYzTS6so3HUG
- 文件是否可以放入统一ps的目录中，在统一ps未开发完之前也能正常调用？
- 此处的 BasicAucCalculator 和 paddlebox 中的 BasicAucCalculator 是什么关系？
- 需要新增 metrics 基类，方便后续开发
There was a problem hiding this comment.
先进行功能合入，后续再考虑放入统一ps
|
Sorry to inform you that 4382e31's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
… dev_add_metrics_module
Thunderbrook
previously approved these changes
Jan 27, 2022
fuyinno4
previously approved these changes
Jan 27, 2022
fuyinno4
approved these changes
Jan 28, 2022
ziyoujiyi
approved these changes
Jan 28, 2022
ziyoujiyi
approved these changes
Jan 28, 2022
WorgenZhang
added a commit
to WorgenZhang/Paddle
that referenced
this pull request
Jan 28, 2022
…ddle#38789) * [PSLIB] Add Metrics Module, Support User-defined Add Metric * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI Coverage * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI Coverage * [PSLIB] Modify According to CI Coverage * [PSLIB] Modify According to CI Coverage * modify role_maker * update CMakeLists.txt
fuyinno4
pushed a commit
that referenced
this pull request
Jan 28, 2022
* 12.3 first add metrics module * add Mask/MultiTask * add WuAUC * [PSLIB] Update WuAUC Compute * [PSLIB] Change WuAUC Compute Mehod * [PSLIB] Clean WuAUC Compute * [PSLIB] Clean Metric Module Unused Code * mv metric instance * [PSLIB] Add Metrics Module, Support User-defined Add Metric (#38789) * [PSLIB] Add Metrics Module, Support User-defined Add Metric * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI Coverage * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI Coverage * [PSLIB] Modify According to CI Coverage * [PSLIB] Modify According to CI Coverage * modify role_maker * update CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe