[PTen]Refactor impl of elementwise op grad_kernel (Part2) #38898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
MingMingShangTian
approved these changes
Jan 14, 2022
chenwhql
approved these changes
Jan 14, 2022
zyfncg
approved these changes
Jan 14, 2022
Comment on lines
153
to
+158
| pten::funcs::ElemwiseGradComputeNoBroadcast<DeviceContext, T, DX_OP, DY_OP, | ||
| Tout>( | ||
| dev_ctx, x_dim, y_dim, x, y, out, dout, axis, dx, dy, dx_op, dy_op); | ||
| } else { | ||
| ElemwiseGradComputeWithBroadcast<DeviceContext, T, DX_OP, DY_OP, Tout>( | ||
| ctx, x_dim, y_dim, x, y, out, dout, axis, dx, dy, dx_op, dy_op); | ||
| pten::ElemwiseGradComputeWithBroadcast<T, DX_OP, DY_OP, Tout>( | ||
| dev_ctx, x_dim, y_dim, x, y, out, dout, axis, dx, dy, dx_op, dy_op); |
There was a problem hiding this comment.
ElemwiseGradComputeNoBroadcast和ElemwiseGradComputeWithBroadcast现在一个在funcs的namespace下，一个在pten的namespace，是不放在一起比较好？
There was a problem hiding this comment.
这个我之前也比较纠结，但还是按原则来了，因为一个是cpu单独使用的，一个是多设备共用的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
将elementwise op的反向kernel底层实现重构迁移到pten目录下，这个pr是第二部分