[Unify Tensors PR #8] Merged Tensor into DenseTensor, test=allcases #38914
Conversation
…/jim19930609/Paddle into all_in_dense_tensor
|
Thanks for your contribution! |
… all_in_dense_tensor
jim19930609
force-pushed
the
all_in_dense_tensor
branch
from
12ed2c2
to
d9b8571
Compare
jim19930609
force-pushed
the
all_in_dense_tensor
branch
from
d9b8571
to
f84e366
Compare
jim19930609
force-pushed
the
all_in_dense_tensor
branch
from
311d5ef
to
ba15747
Compare
jim19930609
force-pushed
the
all_in_dense_tensor
branch
from
e3e84a6
to
2f50505
Compare
jim19930609
force-pushed
the
all_in_dense_tensor
branch
from
2f50505
to
320eca1
Compare
… all_in_dense_tensor
… all_in_dense_tensor
| @@ -159,7 +159,9 @@ class DenseTensor : public TensorBase, | |||
| /// \param dims The new dims of the dense tensor. | |||
| /// \param lod The new lod of the dense tensor. | |||
| // void Resize(const DDim& dims); | |||
| void Resize(const DDim& dims); | |||
| void ResizeAndAllocate(const DDim& dims); | |||
There was a problem hiding this comment.
DenseTensor::Resize 的处理建议：pten 中使用 ResizeAndAllocate，fluid 原有 Resize 的调用不作修改
| @@ -69,7 +69,8 @@ class OneHotV2CUDAKernel : public framework::OpKernel<T> { | |||
| auto* depth_tensor = context.Input<framework::Tensor>("depth_tensor"); | |||
| if (platform::is_gpu_place(depth_tensor->place())) { | |||
| framework::Tensor temp; | |||
| TensorCopySync(*depth_tensor, platform::CPUPlace(), &temp); | |||
| paddle::framework::TensorCopySync(*depth_tensor, platform::CPUPlace(), | |||
There was a problem hiding this comment.
请问类似的添加 paddle::framework:: 的原因是什么？原先是否就在这个名称空间里呢
There was a problem hiding this comment.
这个比较诡异，还想请教一下：以这个文件为例，你会发现他的默认名称空间是paddle::operators::，但是TensorCopySync的名称空间是paddle::framework::。在这个PR之前不需要指定"framework::"即可调用TensorCopySync，而且可以编过，但是我没想明白编译器是怎么做的name resolution。
There was a problem hiding this comment.
可能是 ADL 引发的，在参数名称空间变化后，函数签名不再去原命名空间查找。这个行为可能是符合标准规定的。
|
@jim19930609 在这些提交合入后，Tensor 仍处于一个可在 Fluid 推全，但暂时不能直接使用到 INFRT，且与决策表有差别的状态。其中 INFRT 的适配我来继续开展。目前这些工作可能需要和后续负责的同学交代清楚，所以需要一个总体的状态表。我们一起整理出这个表吧。 |
… all_in_dense_tensor
jim19930609
dismissed stale reviews from chenwhql and Shixiaowei02
via
20a1e3a
… all_in_dense_tensor
PR types
Others
PR changes
Others
Describe
Previous works on constructing new tensor library "pten" introduced another Tensor type namely "DenseTensor", which temporarily co-exists with framework::Tensor and LoDTensor. This is the final PR, in which we removed "class Tensor" completely and all previous access to Tensor will be routed to DenseTensor.