-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PTen]Migrate proto::VarType outside of Pten #39411
Merged
Aurelius84
merged 39 commits into
PaddlePaddle:develop
from
Aurelius84:migrate_var_type
Feb 15, 2022
Merged
[PTen]Migrate proto::VarType outside of Pten #39411
Aurelius84
merged 39 commits into
PaddlePaddle:develop
from
Aurelius84:migrate_var_type
Feb 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenwhql
previously approved these changes
Feb 11, 2022
chenwhql
previously approved these changes
Feb 11, 2022
XiaoguangHu01
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chenwhql
approved these changes
Feb 14, 2022
ZzSean
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for op benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
主要工作:
proto::VarType
从Pten中迁移出去,实现与Pten解耦convert_utils.cc
迁移到fluid目录下,并将TransToProtoType
和TransToPtenType
一并迁移type()
和dtype
接口,为后续移除type()
+saved_type()
接口做准备贡献RD: @2742195759