fix RecordEvent interface #39675
Merged
fix RecordEvent interface #39675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
liutiexing
requested changes
Feb 17, 2022
| RecordEvent::RecordEvent(const std::string &name, const EventRole role, | ||
| uint32_t level) { | ||
| RecordEvent::RecordEvent(const std::string &name, const TracerEventType type, | ||
| uint32_t level, const EventRole role) { |
liutiexing
approved these changes
Feb 17, 2022
liutiexing
requested changes
Feb 17, 2022
| explicit RecordEvent( | ||
| const std::string& name, | ||
| const TracerEventType type = TracerEventType::UserDefined, | ||
| uint32_t level = 4, const EventRole role = EventRole::kOrdinary); |
There was a problem hiding this comment.
把默认level 4定义一个const常量，这样用户需要设置后面的默认参数而不想改level时可以用这个
liutiexing
requested changes
Feb 17, 2022
| explicit RecordEvent(const std::string& name, | ||
| const EventRole role = EventRole::kOrdinary, | ||
| uint32_t level = 1); | ||
| explicit RecordEvent( |
There was a problem hiding this comment.
修改接口会导致部分使用EventRole的case无法编译，需要修改这些
…_record_event_interface
liutiexing
requested changes
Feb 18, 2022
paddle/fluid/framework/operator.cc
Outdated
| @@ -261,10 +262,12 @@ void OperatorBase::Run(const Scope& scope, const platform::Place& place) { | |||
| // TODO(wangchaochaohu) : refine code to use only one RecordEvent) | |||
| // in order to record different op type cost time | |||
| // and different op name cost time,we set two event. | |||
| platform::RecordEvent op_type_record_event(Type()); | |||
| platform::RecordEvent op_type_record_event( | |||
| Type(), platform::TracerEventType::Operator, 1); | |||
There was a problem hiding this comment.
const std::string& Type() const { return type_; }
写成Type().c_str()
否则性能会差
There was a problem hiding this comment.
string类型会导致memcpy，尽量用const char*
| const EventRole role = EventRole::kOrdinary, | ||
| uint32_t level = 1); | ||
| explicit RecordEvent(const char* name, const TracerEventType type = | ||
| TracerEventType::UserDefined, |
…_record_event_interface
liutiexing
approved these changes
Feb 18, 2022
| DygraphInferShapeContext<VarType> infer_shape_ctx( | ||
| &ins, &outs, &attrs, &default_attrs, op.Type(), &kernel_type); | ||
| op.Info().infer_shape_(&infer_shape_ctx); | ||
| } | ||
|
|
||
| { | ||
| platform::RecordEvent record_event(op.Type() + " compute", | ||
| platform::EventRole::kInnerOp); | ||
| platform::RecordEvent record_event(op.Type() + "::compute", |
There was a problem hiding this comment.
这种尽量避免，新执行器只需要记录compute，无需op name，老执行器可以保持和原来一致
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
往RecordEvent中多加入一个参数，服务于新的Profiler使用。