move eye、size、erfinv、pixel_shuffle OP to phi #39712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
0x45f
changed the title
YuanRisheng
reviewed
Feb 22, 2022
| DenseTensor* out) { | ||
| auto place = ctx.GetPlace(); | ||
| auto out_data = ctx.template Alloc<int64_t>(out); | ||
| auto cpu_place = paddle::platform::CPUPlace(); |
| cpu_tensor.Resize(out->dims()); | ||
| auto cpu_data = ctx.template HostAlloc<int64_t>(&cpu_tensor); | ||
| cpu_data[0] = input.numel(); | ||
| paddle::framework::TensorCopy(cpu_tensor, place, out); |
There was a problem hiding this comment.
可以尝试使用phi下的copy_kernel来替换fluid下的TensorCopy
chenwhql
reviewed
Feb 22, 2022
paddle/phi/kernels/cpu/eye_kernel.cc
Outdated
| double, | ||
| int64_t, | ||
| int, | ||
| paddle::platform::float16) {} |
| phi::SizeKernel, | ||
| int, | ||
| int64_t, | ||
| paddle::platform::float16, |
| #include "paddle/phi/backends/gpu/gpu_context.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/impl/pixel_shuffle_grad_kernel_impl.h" | ||
| #include "paddle/phi/kernels/pixel_shuffle_grad_kernel.h" |
There was a problem hiding this comment.
kernel声明头文件在最前面，可以和其他的宏空行隔开
| #include "paddle/phi/backends/gpu/gpu_context.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/impl/pixel_shuffle_kernel_impl.h" | ||
| #include "paddle/phi/kernels/pixel_shuffle_kernel.h" |
| phi::SizeKernel, | ||
| int, | ||
| int64_t, | ||
| paddle::platform::float16, |
| auto dx_dims = dx->dims(); | ||
|
|
||
| DenseTensor t; | ||
| t.ShareDataWith(*dout); |
There was a problem hiding this comment.
这里感觉原来就写的比较trick，现在ShareDataWith其实就是浅拷贝，所以可以改成直接copy一个tensor，例如：DenseTensor t(*dout)
| auto o_dims = out->dims(); | ||
|
|
||
| DenseTensor t; | ||
| t.ShareDataWith(*in); |
paddle/phi/ops/compat/erfinv_sig.cc
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Unless required by applicable law or agreed to in writing, software |
paddle/phi/ops/compat/eye_sig.cc
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Unless required by applicable law or agreed to in writing, software |
paddle/phi/ops/compat/size_sig.cc
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Unless required by applicable law or agreed to in writing, software |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
调用ForRange需要include fluid