[KP] Add elementwise add xpu after phi, test=develop #39787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Liu-xiandong
changed the title
AnnaTrainingG
approved these changes
Feb 22, 2022
| @@ -127,9 +127,11 @@ macro(compile_kernel COMPILE_ARGS) | |||
| kernel_build/${kernel_name}.bin.o | |||
| COMMAND | |||
| ${CMAKE_COMMAND} -E make_directory kernel_build | |||
| COMMAND | |||
| cp ${kernel_path}/${kernel_name}.kps kernel_build/${kernel_name}.xpu | |||
There was a problem hiding this comment.
GPU环境下是否需要cp 成.cu文件呢
There was a problem hiding this comment.
是的，目前直接转成.cu文件还有一些工作量，后续提PR完成
| REGISTER_OP_KERNEL(elementwise_add, KP, plat::XPUPlace, | ||
| ops::ElementwiseAddXPUKPKernel<float>); | ||
|
|
||
| REGISTER_OP_KERNEL(elementwise_add_grad, KP, plat::XPUPlace, |
There was a problem hiding this comment.
此处只有XPU 注册，那GPU注册添加到哪里呢
|
|
||
| #define KPStream XPUStream | ||
| #define KPDevice phi::XPUContext | ||
| #define _ptr_ _global_ptr_ | ||
| #define __forceinline__ __inline__ | ||
| #define __restrict__ | ||
|
|
||
| #include "paddle/phi/backends/xpu/xpu_context.h" |
xingfeng01
approved these changes
Feb 22, 2022
| @@ -17,7 +17,7 @@ if(NOT WITH_XPU_KP) | |||
| endif() | |||
|
|
|||
| if(NOT XPU_TOOLCHAIN) | |||
| set(XPU_TOOLCHAIN /workspace/paddle/xpu-demo/XTDK) | |||
| set(XPU_TOOLCHAIN /workspace/output/XTDK-ubuntu_x86_64) | |||
qili93
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New featuresPR changes
OPs
Describe
Added kernel for XPU2 KP system, elementwise_add
This PR involves 4 changes:
Improve the XPU2 source code compilation process, modify cmake/operators.cmake and cmake/xpu_kp.cmake to support .kps files.
Added the elementwise_add.kps file and added a test for it. This file provides the forward XPU2 source code compilation code of elementwise_add
Modified the relevant components of KP, compute_primitives_xpu2.h, etc., and solved some previous bugs
In order to support source code compilation of XPU2, some underlying codes such as elementwise and device have been modified, such as elementwise_base.h and cuda_kernel_config.h, etc.
The result is as follows:
The KP_flags turns on:
