[phi] migrate atan2_op into phi #39806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -225,4 +225,9 @@ void HuberLossInferMeta(const MetaTensor& input, | |||
| out->share_lod(input); | |||
| } | |||
|
|
|||
| void Atan2InferMeta(const MetaTensor& x, const MetaTensor& y, MetaTensor* out) { | |||
| auto in_dims = x.dims(); | |||
| out->set_dims(in_dims); | |||
There was a problem hiding this comment.
这里还需要设置dtype， layout，lod
chenwhql
approved these changes
Feb 23, 2022
|
|
||
| #include "paddle/phi/kernels/atan2_grad_kernel.h" | ||
| #include "paddle/phi/backends/cpu/cpu_context.h" | ||
| #include "paddle/phi/core/device_context.h" |
There was a problem hiding this comment.
这个头文件应该可以去掉，只include cpu_context.h就可以
|
|
||
| #include "paddle/phi/kernels/atan2_kernel.h" | ||
| #include "paddle/phi/backends/cpu/cpu_context.h" | ||
| #include "paddle/phi/core/device_context.h" |
| // limitations under the License. | ||
|
|
||
| #include "paddle/phi/backends/gpu/gpu_context.h" | ||
| #include "paddle/phi/core/device_context.h" |
| #include "paddle/phi/backends/gpu/gpu_context.h" | ||
| #include "paddle/phi/core/device_context.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/atan2_kernel.h" |
There was a problem hiding this comment.
kernel头文件建议放到最上面，和下面的用空格隔开
|
|
||
| #include "paddle/fluid/platform/for_range.h" | ||
| #include "paddle/phi/core/dense_tensor.h" | ||
| #include "paddle/phi/kernels/atan2_grad_kernel.h" |
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include "paddle/phi/kernels/atan2_kernel.h" |
There was a problem hiding this comment.
这里加一个空行，隔开本身实现的atan2_kernel.h 头文件和其他依赖的头文件
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include "paddle/phi/kernels/atan2_grad_kernel.h" |
There was a problem hiding this comment.
这里加一个空行，隔开本身实现的atan2_kernel.h 头文件和其他依赖的头文件
| #include "paddle/phi/backends/gpu/gpu_context.h" | ||
| #include "paddle/phi/core/device_context.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/atan2_grad_kernel.h" |
MingMingShangTian
approved these changes
Feb 23, 2022
chenwhql
reviewed
Feb 23, 2022
| @@ -225,4 +225,9 @@ void HuberLossInferMeta(const MetaTensor& input, | |||
| out->share_lod(input); | |||
| } | |||
|
|
|||
| void Atan2InferMeta(const MetaTensor& x, const MetaTensor& y, MetaTensor* out) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
migrate atan2_op into phi