Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add complex type compatibility for stft api and stft op. #40113

Merged
merged 11 commits into from
Mar 23, 2022
Merged

Add complex type compatibility for stft api and stft op. #40113

merged 11 commits into from
Mar 23, 2022

Conversation

KPatr1ck
Copy link
Contributor

@KPatr1ck KPatr1ck commented Mar 3, 2022 •
edited
Loading

PR types

Function optimization

PR changes

OPs, APIs

Describe

  1. 重组spectral_op代码
  2. 新增stft op，正反向Kernel和op单测，支持2D的音频Batch输入
  3. 修复stft api在静态图中对复数的兼容性问题：
    • OP侧
      • 修复frame_op和overlap_add_op在静态图模式下InferShape的问题
      • mean_op新增注册复数类型Kernel
      • pad3d_op新增注册复数类型Kernel
    • API侧
      • signal.py的api完善数据类型逻辑
      • abs, transpose, squeeze, unsqueeze, matmul, fill_constant 静态图数据类型检测中增加复数类型

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 3, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@KPatr1ck KPatr1ck changed the title Stft op Add complex compatibility for stft api and stft op. Mar 3, 2022
@KPatr1ck KPatr1ck changed the title Add complex compatibility for stft api and stft op. Add complex type compatibility for stft api and stft op. Mar 3, 2022
@KPatr1ck
Copy link
Contributor Author

PaddlePaddle/PaddleSpeech#1289

@paddle-bot-old
Copy link

Sorry to inform you that 1b78d6c's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@zh794390558 zh794390558 mentioned this pull request Mar 14, 2022
Closed
4 tasks
@KPatr1ck KPatr1ck marked this pull request as ready for review March 16, 2022 05:44
@ZeyuChen ZeyuChen self-assigned this Mar 18, 2022
@jerryuhoo
Copy link

@KPatr1ck 您好，我发现istft动转静complex type也会报错，然后找到了您这个pr，请问是否有修复istft api动转静的计划呢？非常感谢！

iclementine
iclementine previously approved these changes Mar 18, 2022
View reviewed changes
Copy link

@iclementine iclementine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iclementine
Copy link

fill constant like 也添加了复数类型，PR 说明里也可以加一下

@KPatr1ck
Copy link
Contributor Author

@KPatr1ck 您好，我发现istft动转静complex type也会报错，然后找到了您这个pr，请问是否有修复istft api动转静的计划呢？非常感谢！

这个pr也支持istft动转静。

ZeyuChen
ZeyuChen previously approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 previously approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KPatr1ck KPatr1ck dismissed stale reviews from XiaoguangHu01 and ZeyuChen via ef47b64 March 22, 2022 07:30
ZeyuChen
ZeyuChen approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeyuChen ZeyuChen merged commit 319f95d into PaddlePaddle:develop Mar 23, 2022
@jerryuhoo jerryuhoo mentioned this pull request Apr 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeyuChen ZeyuChen ZeyuChen approved these changes

@iclementine iclementine iclementine left review comments

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 left review comments

Assignees

@ZeyuChen ZeyuChen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KPatr1ck @jerryuhoo @iclementine @ZeyuChen @XiaoguangHu01