Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiler features #40357

Merged
merged 49 commits into from
Mar 23, 2022
Merged

Conversation

rainyfly
Copy link
Contributor

@rainyfly rainyfly commented Mar 9, 2022

PR types

Others

PR changes

Others

Describe

框架加入Profiler特性。该PR包括:

  1. C++层加入Flag,判断当前编译是否包括CUPTI来做Nv GPU的性能分析,修复cpu utilization的计算bug。
  2. Python层加入对模型dataloader, forward, backward, optimizer过程的打点记录。
  3. 完善统计表单。
  4. 修改接口对应的文档。
  5. 该pr结束一期的profiler功能。

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 9, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

liutiexing
liutiexing previously approved these changes Mar 9, 2022
@rainyfly
Copy link
Contributor Author

Done

@@ -36,10 +38,16 @@
]


@deprecated(
since="2.2.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下一个待发布的版本应该是2.3.0,3位版本一般不修改api

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改

XiaoguangHu01
XiaoguangHu01 previously approved these changes Mar 18, 2022
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG API

TCChenlong
TCChenlong previously approved these changes Mar 21, 2022
@rainyfly rainyfly dismissed stale reviews from TCChenlong and XiaoguangHu01 via b62a430 March 21, 2022 07:46
@@ -138,15 +157,16 @@ def export_chrome_tracing(dir_name: str,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里少了返回 需要和中文一致~

@@ -138,15 +157,16 @@ def export_chrome_tracing(dir_name: str,

Examples:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

示例代码中英文不一致,建议使用 COPY:FROM 保持中英一致

TCChenlong
TCChenlong previously approved these changes Mar 22, 2022
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:Fix API docs,PaddlePaddle/docs#4291

Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit c15e382 into PaddlePaddle:develop Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants