fix IterableDataset may block model when num_workers > 0 #40541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
qingqing01
approved these changes
Mar 15, 2022
liqitong-a
pushed a commit
to liqitong-a/Paddle
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
fix IterableDataset may block model when num_workers > 0
DataLoaderhaspy_readerandblocking_queueafter multi-process processing, blocking queue capacity is2 * num_workers，which can store all prefetched data, so when_rcvd_idxcatch up_send_idx, beside the situation that all data source drained, it can be all prefetch data stored in blocking queue to wait for network reading data. In this situation, thread ofDataLoadershould not occupy CPU time, simply let it go to_data_queue.get_data，this method will blocking when_data_queuedo not have data, and CPU time can be used for model running.If use
continuehere,_rcvd_idxand_send_idxchecking may keep looping, which may occupy CPU time for model running