Call sparse op from python #40608
Merged
Call sparse op from python #40608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zyfncg
reviewed
Mar 16, 2022
| @@ -1038,7 +1041,8 @@ def GenerateNodeCCFile(filepath, node_definition_str): | |||
| #include "paddle/fluid/eager/api/generated/eager_generated/backwards/nodes.h" | |||
| #include "paddle/fluid/eager/to_static/run_program_op_node.h" | |||
|
|
|||
| #include "paddle/phi/api/include/sparse_api.h" | |||
| //#include "paddle/phi/api/include/sparse_api.h" | |||
Comment on lines
33
to
50
| Backend kernel_backend = Backend::UNDEFINED; | ||
| DataLayout kernel_layout = DataLayout::UNDEFINED; | ||
| DataType kernel_data_type = DataType::UNDEFINED; | ||
| if (kernel_backend == Backend::UNDEFINED || | ||
| kernel_layout == DataLayout::UNDEFINED || | ||
| kernel_data_type == DataType::UNDEFINED) { | ||
| auto kernel_key_set = ParseKernelKeyByInputArgs(x); | ||
| auto kernel_key = kernel_key_set.GetHighestPriorityKernelKey(); | ||
| if (kernel_backend == Backend::UNDEFINED) { | ||
| kernel_backend = kernel_key.backend(); | ||
| } | ||
| if (kernel_layout == DataLayout::UNDEFINED) { | ||
| kernel_layout = kernel_key.layout(); | ||
| } | ||
| if (kernel_data_type == DataType::UNDEFINED) { | ||
| kernel_data_type = kernel_key.dtype(); | ||
| } | ||
| } |
There was a problem hiding this comment.
如果自定义实现的话不用写的这么复杂，直接kernel_key拿出来用就行
| @@ -83,32 +102,50 @@ Tensor to_sparse_coo_impl(const Tensor& x, | |||
| out.set_impl(coo); | |||
|
|
|||
| // 6. Call kernel | |||
| VLOG(6) << "call kernel "; | |||
There was a problem hiding this comment.
这种内容比较少的VLOG感觉可以去掉或者把级别调大一些
| @@ -201,7 +207,9 @@ void DenseToSparseCooKernel(const Context& dev_ctx, | |||
| temp_indexs_ptr, | |||
| indices_data, | |||
| sparse_data); | |||
| VLOG(6) << "set member"; | |||
jim19930609
previously approved these changes
Mar 16, 2022
jim19930609
previously approved these changes
Mar 17, 2022
added 2 commits
March 17, 2022 02:25
zyfncg
previously approved these changes
Mar 18, 2022
zyfncg
previously approved these changes
Mar 19, 2022
zyfncg
approved these changes
Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
PD_REGISTER_API(Test);test_sparse_utils_op.py，todo：目前是测试_C_ops下的接口，后面需要改成paddle.sparse.相应API。