Scalar support marking data_type in yaml #40867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenwhql
reviewed
Mar 24, 2022
| @@ -89,6 +89,11 @@ def parse_input_and_attr(self, api_name, args_config, optional_vars=[]): | |||
| attr_types_map = { | |||
| 'ScalarArray': 'const ScalarArray&', | |||
| 'Scalar': 'const Scalar&', | |||
| 'Scalar(int)': 'const Scalar&', | |||
| 'Scalar(int32)': 'const Scalar&', | |||
| 'Scalar(int32)': 'const Scalar&', | ||
| 'Scalar(int64)': 'const Scalar&', | ||
| 'Scalar(float)': 'const Scalar&', | ||
| 'Scalar(dobule)': 'const Scalar&', | ||
| 'uint8': 'uint8_t', | ||
| 'int': 'int', | ||
| 'int32': 'int32_t', |
There was a problem hiding this comment.
同上，统一命名风格，要不和C++类型对齐，要不和DataType的标记类型对齐，避免模棱两可的数据类型命名
There was a problem hiding this comment.
Done. 对于attribute的写法向C++类型对齐
chenwhql
reviewed
Mar 24, 2022
| @@ -37,6 +37,11 @@ | |||
| 'Tensor[]' : 'std::vector<Tensor>', | |||
| 'Tensor[Tensor[]]' : 'std::vector<std::vector<Tensor>>', | |||
| 'Scalar' : 'paddle::experimental::Scalar', | |||
| 'Scalar(int)' : 'paddle::experimental::Scalar', | |||
There was a problem hiding this comment.
目前只支持int,int64_t,float和double四种配置，已基本覆盖目前使用Scalar的attribute类型，后续是否新增需要根据具体需求来决定。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Yaml配置中支持为Scalar类型参数指定特定数据类型，标记方式为
Scalar(Type), 如Scalar(int) axis