Optimize the perf of top_k when k is too large #40941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Zjq9409
reviewed
Mar 28, 2022
| Copy(dev_ctx, sorted_output, out->place(), false, out); | ||
| return; | ||
| } else { | ||
| LOG(INFO) << "TopKOP: Some errors happened when use cub sorting, use " |
There was a problem hiding this comment.
这里使用LOG(INFO)，但是后面报错信息有 errors，是不是使用LOG(ERROR)更适合？或者可以使用paddle的报错函数：phi::errors::XXX
There was a problem hiding this comment.
这个并不是说走到这个分支就要退出，而是可以选择后续的分支继续完成计算，所以用errors不太合适
| int k_left = k; | ||
|
|
||
| #pragma unroll | ||
| for (int digit_pos = sizeof(T) * 8 - RADIX_BITS; digit_pos >= 0; |
limin2021
previously approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
Optimize the perf of top_k when k is too large