Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time range duration display #41029

Merged

Conversation

rainyfly
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

  1. 给Chrometracing的时间段名字上面加入了时间的显示,方便查看时间
  2. 修复了一下不足1us即1000ns以内的事件在timeline显示为线条非线段的问题
  3. 控制颜色为3种,防止杂乱过多的问题

@paddle-bot-old paddle-bot-old bot added contributor External developers status: proposed labels Mar 28, 2022
@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

output_file_stream_ << string_format(
std::string(
R"JSON(
{
"name": "%s", "pid": %lld, "tid": "%lld(Python)",
"ts": %lld, "dur": %lld,
"name": "%s[%.3f ms]", "pid": %lld, "tid": "%lld(Python)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如沟通,时间短,us,时间长(大于1ms),用ms

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

liutiexing
liutiexing previously approved these changes Mar 28, 2022
TCChenlong
TCChenlong previously approved these changes Mar 28, 2022
@rainyfly rainyfly dismissed stale reviews from TCChenlong and liutiexing via e190ec4 March 29, 2022 05:16
TCChenlong
TCChenlong previously approved these changes Mar 29, 2022
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for API docs

liutiexing
liutiexing previously approved these changes Mar 29, 2022
@rainyfly rainyfly dismissed stale reviews from liutiexing and TCChenlong via 28939f7 March 30, 2022 02:18
TCChenlong
TCChenlong previously approved these changes Mar 30, 2022
@liutiexing liutiexing merged commit 6744754 into PaddlePaddle:develop Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants