fix new dygraph record event #41715
Merged
fix new dygraph record event #41715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
liutiexing
previously approved these changes
Apr 12, 2022
jim19930609
reviewed
Apr 13, 2022
| @@ -2481,7 +2481,7 @@ static std::string GenerateGradNodeHeaderContents( | |||
| "%s\n" | |||
| " SetIsTensorWrappersCleared(true);\n" | |||
| " }\n" | |||
| " std::string name() override { return \" GradNode%s \"; } \n " | |||
There was a problem hiding this comment.
- "name()" returns the class name, you should change the class name as well.
- Per coding style, better named as "GradNode%sMid" or so.
jim19930609
reviewed
Apr 13, 2022
| @@ -136,7 +136,7 @@ def RemoveConstAndReference(string): | |||
|
|
|||
|
|
|||
| def GetGradNodeName(string): | |||
| return f"FinalGradNode{string}" | |||
| return f"{string}_final_grad_node" | |||
| @@ -643,7 +643,7 @@ std::vector<paddle::experimental::Tensor> RunBackward( | |||
| VLOG(6) << "Running GradNode:" << node->name(); | |||
|
|
|||
| paddle::platform::RecordEvent node_record_event( | |||
| std::string(typeid(*node).name()) + " grad_node", | |||
There was a problem hiding this comment.
Some performance analysis script rely on this " grad_node" suffix to identify GradNode runtime. Please keep this suffix unchanged.
jim19930609
approved these changes
Apr 13, 2022
rainyfly
added a commit
to rainyfly/Paddle
that referenced
this pull request
Apr 13, 2022
* fix new dygraph record event * refine name * fix * fix * fix according to review
XiaoguangHu01
pushed a commit
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe